Skip to content

Don't silently cast non-numeric types when evaluating numeric bounds. #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ian-sift merged 4 commits into from
Mar 31, 2026
Merged

Don't silently cast non-numeric types when evaluating numeric bounds. #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
694c26f
Don't silently cast non-numeric types when evaluating numeric bounds.
ian-sift Mar 30, 2026
171fd57
fmt
ian-sift Mar 30, 2026
01728e9
type ignore since we're raising type error
ian-sift Mar 30, 2026
3095e63
fmt
ian-sift Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions python/lib/sift_client/_tests/util/test_test_results_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,15 @@ def test_evaluate_measurement_bounds_with_numeric_bounds_object(self):
assert measurement.numeric_bounds.min == 0.0
assert measurement.numeric_bounds.max == 10.0

def test_numeric_bounds_bad_value_type(self):
"""Test that an error is raised if the value is not a float or int when evaluating numeric bounds."""
measurement = TestMeasurementUpdate()
with pytest.raises(
TypeError,
match="Value must be a float or int to evaluate numeric bounds but gave <class 'str'>",
):
evaluate_measurement_bounds(measurement, "1", {"min": 0.0, "max": 10.0})

def test_evaluate_measurement_bounds_string_matching(self):
"""Test string value matching expected string."""
measurement = TestMeasurementUpdate()
Expand Down
19 changes: 10 additions & 9 deletions python/lib/sift_client/util/test_results/bounds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,14 @@ def evaluate_measurement_bounds(
elif isinstance(bounds, NumericBounds):
measurement.numeric_bounds = bounds
measurement.passed = True
float_value = float(value)
if measurement.numeric_bounds.min is not None:
measurement.passed = (
measurement.passed and measurement.numeric_bounds.min <= float_value
)
if measurement.numeric_bounds.max is not None:
measurement.passed = (
measurement.passed and measurement.numeric_bounds.max >= float_value
)
try:
if measurement.numeric_bounds.min is not None:
measurement.passed = measurement.passed and measurement.numeric_bounds.min <= value # type: ignore
if measurement.numeric_bounds.max is not None:
measurement.passed = measurement.passed and measurement.numeric_bounds.max >= value # type: ignore
except TypeError:
raise TypeError(
f"Value must be a float or int to evaluate numeric bounds but gave {type(value)}"
) from None

return bool(measurement.passed)
Loading