python(fix): add py.typed file to proto dir#524
Merged
Conversation
alexluck-sift
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed:
Our proto package generates .pyi type stubs via
mypy-protobuf, but without a PEP 561py.typedmarker file, type checkers ignore them entirely. This means downstream consumers (and our own Mypy) silently treat all proto imports as Any, no real type checking occurs on proto types.Added an empty
py.typedfile to the sift proto package directory and toml so type checkers discover and use the existing stubs.Validation
Existing tests passed and verified a local installation of sift-stack-py included the py.typed marker in the sift proto directory.