Implement adm check — state validation#23
Merged
Conversation
Working `adm check` that: - Validates .adm/project.json against Pydantic schema - Checks artefact directories exist for completed phases - Reports open CLR-NNN clarifications per domain - Runs invariant pytest suite (subprocess) for Phase 3+ domains - Rich-formatted output with severity colours - Exits 0 on pass, 1 on errors (warnings don't block) - Supports --domain flag for single-domain check - Multi-domain iteration with aggregated findings Full Spec Kit workflow: specify → clarify → plan → tasks → analyze → implement. 41 tests pass (13 new for check). Closes #5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
adm check— validates project state integrity, artefact directory existence, CLR resolution status, and optionally runs the invariant pytest suite. Rich-formatted output with severity colours and reliable exit codes for CI integration.Changes
src/adm_cli/check.py— check command with Severity enum, CheckFinding, CheckReport, validation logic, invariant subprocess runnersrc/adm_cli/__init__.py— wired check command with--domainoptiontests/test_check.py— 13 tests covering all acceptance criteriaspecs/005-adm-check/— full Spec Kit workflow artefacts (spec, plan, data-model, tasks, checklist)Linked Issues
Closes #5
Test Plan
uv run --group dev pytest -v)--domainflag restricts to single domainChecklist
specs/005-adm-check/spec.md