Implement phase gate enforcement in state manager#25
Merged
Conversation
Adds gates.py with: - can_advance(domain, target_phase) -> (bool, reason) - advance_phase(domain) — increment + atomic save - Validates prior phase artefacts exist (from template frontmatter) - Ratchet gate: blocks on open CLR-NNN clarifications - Rejects phase skipping and advancement beyond phase 7 Added pyyaml dependency for template frontmatter parsing. 59 tests pass (12 new for gates). Closes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds phase gate enforcement to the state manager —
can_advance()validates prior phase artefacts exist before allowing progression,advance_phase()atomically increments the phase counter. Ratchet gate additionally blocks on open CLR-NNN clarifications.Changes
src/adm_cli/gates.py— gate logic with template frontmatter parsingtests/test_gates.py— 12 tests covering all gate conditionspyproject.toml— added pyyaml dependencyspecs/007-phase-gates/spec.md— feature specLinked Issues
Closes #7
Test Plan
Checklist
specs/007-phase-gates/spec.md