Implement clarify-gate pattern#26
Merged
Merged
Conversation
Adds clarify.py with: - raise_clr() — create new CLR-NNN question (sequential IDs) - resolve_clr() — mark a CLR as resolved - merge_clarifications() — merge/overwrite/skip modes for phase re-runs - next_clr_id() — compute next available ID - get_clr_summary() — open vs resolved counts Resolutions persist in .adm/project.json and survive phase re-runs under default merge behaviour. Never silently discards analyst decisions. 73 tests pass (14 new for clarify). Closes #8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the clarify-gate pattern — structured CLR-NNN questions that persist across phase re-runs. Supports three merge modes (merge/overwrite/skip) to control how new questions interact with existing resolutions.
Changes
src/adm_cli/clarify.py— raise_clr, resolve_clr, merge_clarifications, next_clr_id, get_clr_summarytests/test_clarify.py— 14 tests covering all merge modes, ID sequencing, persistencespecs/008-clarify-gate/— spec and checklistLinked Issues
Closes #8
Test Plan
Checklist
specs/008-clarify-gate/spec.md