Distance measure signature#17
Merged
AmitMY merged 23 commits intosign-language-processing:mainfrom Mar 6, 2025
Merged
Conversation
AmitMY
requested changes
Feb 27, 2025
AmitMY
requested changes
Mar 1, 2025
Contributor
AmitMY
left a comment
AmitMY
left a comment
There was a problem hiding this comment.
still minor comments. realistically, did not give a deep review to this modification.
AmitMY
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #16 , adding DistanceMeasure and its corresponding signature. Tested out PowerDistance as well.
Original implementation from https://github.com/sign-language-processing/pose-evaluation/pull/4/files#diff-659180695d72a834de58010e799dfe4ae805a36f40897d5dfab91fb3320838b8 needed tweaking to work with masked arrays. This one gives expected results. For example, if a point is masked, it correctly substitutes in the default value as expected.
Also set it up so you can easily calculate all the pointwise distances, then sum(), or mean() or otherwise aggregate() them.
I had thought of creating an AggregationStrategy class, but I think it might not be necessary
@AmitMY any thoughts/suggestions?