Skip to content

messaging apis#304

Merged
Devon-White merged 4 commits intomainfrom
Devon/messaging-endpoints
Apr 27, 2026
Merged

messaging apis#304
Devon-White merged 4 commits intomainfrom
Devon/messaging-endpoints

Conversation

@Devon-White
Copy link
Copy Markdown
Collaborator

No description provided.

@Devon-White Devon-White marked this pull request as ready for review April 24, 2026 17:46
@Devon-White Devon-White requested a review from cassieemb April 24, 2026 17:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

@cassieemb cassieemb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good! I noticed one mismatch with the direction, but the other comments are non blocking suggestions.

Do we want to include the status callback body they will receive when the status callback URL is set as well? (the same status callback body will be used for RELAY SDK message callbacks and SWML send_sms status callbacks too)

{
  "id": "a1b2c3d4-e5f6-7890-abcd-ef1234567890",
  "project_id": "b2c3d4e5-f6a7-8901-bcde-f12345678901",
  "status": "delivered",
  "to": "+15551234567",
  "from": "+15559876543",
  "body": "Hello World!",
  "number_of_segments": 1,
  "timestamp": "2026-03-17T22:26:57Z",
  "error_code": null,
  "error_message": null
}

Comment thread fern/apis/signalwire-rest/openapi.yaml Outdated
Comment thread fern/apis/signalwire-rest/openapi.yaml Outdated
Comment thread fern/apis/signalwire-rest/openapi.yaml Outdated
Comment thread specs/signalwire-rest/message-api/messages/models/core.tsp Outdated
cassieemb
cassieemb previously approved these changes Apr 27, 2026
Copy link
Copy Markdown
Contributor

@cassieemb cassieemb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One thing I noticed on the preview is that the status callback link led to an empty page, but I was able to access the actual page from there - not sure if that's a preview issue or a real one.

link took me to -> https://signalwire-preview-8890b342-55dd-413d-ac48-907edbb16a32.docs.buildwithfern.com/docs/apis/rest/signalwire-rest/messages/webhooks/message-status-callback

Image

following last option took me to https://signalwire-preview-8890b342-55dd-413d-ac48-907edbb16a32.docs.buildwithfern.com/docs/apis/rest/message-status-callback, which worked correctly

I'm approving in case this is a preview issue only, but will keep an eye out to reapprove if not

@Devon-White
Copy link
Copy Markdown
Collaborator Author

LGTM! One thing I noticed on the preview is that the status callback link led to an empty page, but I was able to access the actual page from there - not sure if that's a preview issue or a real one.

link took me to -> https://signalwire-preview-8890b342-55dd-413d-ac48-907edbb16a32.docs.buildwithfern.com/docs/apis/rest/signalwire-rest/messages/webhooks/message-status-callback

Image following last option took me to https://signalwire-preview-8890b342-55dd-413d-ac48-907edbb16a32.docs.buildwithfern.com/docs/apis/rest/message-status-callback, which worked correctly

I'm approving in case this is a preview issue only, but will keep an eye out to reapprove if not

Looks like Fern isn't flagging broken links inside api specs, which is why this was uncaught. Pushing a fix :)

Devon-White and others added 2 commits April 27, 2026 12:27
Mirror the campaign-registry pattern: extract MessageStatusCallbackPayload
to its own webhooks.tsp, attach @webhook at the messages namespace level
with explicit MESSAGES_TAG, and add a Webhooks subsection under Messages
in apis.yml. Auto-tag resolution failed because create() spreads
CreateMessageRequest, so the model was never seen as an operation
parameter; the explicit tag fixes the broken
/messages/webhooks/message-status-callback link.
@Devon-White Devon-White merged commit 8fbfb6c into main Apr 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants