Skip to content

🎨 Refactor the method #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olistik wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🎨 Refactor the method #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c9e09a
🎨 Refactor the method
olistik Feb 25, 2020
790bb01
Merge branch 'master' into refactor-method
emcgee Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions lib/signalwire/relay/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,23 +69,25 @@ def relay_execute(command, timeout = Signalwire::Relay::COMMAND_TIMEOUT, &block)

promise.wait timeout

if promise.fulfilled?
event = promise.value
code = event.dig(:result, :result, :code)
message = event.dig(:result, :result, :message)
success = code == '200' ? :success : :failure

if code
block.call(event, success) if block_given?
logger.error "Relay command failed with code #{code} and message: #{message}" unless success
else
logger.error("Relay error occurred, code #{event.error_code}: #{event.error_message}") if event.error?
block.call(event, :failure) if block_given?
end
else
unless promise.fulfilled?
logger.error 'Unknown Relay command failure, command timed out'
block.call(event, :failure) if block_given?
return
end

event = promise.value
code = event.dig(:result, :result, :code)
message = event.dig(:result, :result, :message)
success = code == '200' ? :success : :failure

unless code
logger.error("Relay error occurred, code #{event.error_code}: #{event.error_message}") if event.error?
block.call(event, :failure) if block_given?
return
end

block.call(event, success) if block_given?
logger.error "Relay command failed with code #{code} and message: #{message}" unless success
end

def calling
Expand Down