Added support to disable suggestion selection#719
Added support to disable suggestion selection#719jack-lewin wants to merge 5 commits intosignavio:masterfrom
Conversation
If a suggestion is disabled... - Set aria-disabled=true - Apply style - Don't handle onSelect Co-authored-by: Maks <sulimmaxim@gmail.com>
🦋 Changeset detectedLatest commit: 47b3c68 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @Sigrsig & @steffektif, sorry for the nudge - are you still maintaining this project? |
|
Hey sorry, already the last time you reached out I pinged some people. Currently @PreussHendrik and @crecotun are in charge. I hope they see this message and can help you out |
|
Thanks a lot @steffektif - appreciate it 🙂 |
|
Hi, @PreussHendrik and @crecotun! I'd really appreciate a review here - might one of you be able to take a look please? Let me know if there's anything I can do to help get this merged. |
|
Hi @jack-lewin |
|
Thank you for working on this! Hope this gets merged soon! |
|
It was a busy 2 weeks; I'll have a look at PR today |
| (props) => ({ | ||
| '&focused': props.focused, | ||
| '&disabled': Boolean( | ||
| typeof props.suggestion === 'string' ? false : props.suggestion.disabled |
There was a problem hiding this comment.
Why do you check here if 'suggestion' is string before accessing disabled properly, but on a line 74, you don't?
There was a problem hiding this comment.
Hey @crecotun 👋 I'd love to get this one merged - would you mind taking another look when possible, please?
|
hi, @crecotun, is there any update on this PR? Thank you! |
|
Hello @signavio! 👋 Just a gentle nudge - I've addressed the suggestion from the previous review, and I'd love to get this PR merged. Is there somebody who could take a second look, please? 🙏 |
4 participants
I've picked up #440 to try and get it merged.
This PR adds an optional
disabledprop to suggestions.If a suggestion is
disabled, it...aria-disabled = trueI've also...
If this lands, I'll make a separate PR to the DefinitelyTyped repo.
Feedback appreciated - cc @mastrix, @Sigrsig and @steffektif 🙏