refactor: align core views to a shared visual system#39
Open
rowline wants to merge 1 commit into
Open
Conversation
Introduce SWSpacing / SWRadius enums and a Font extension for typography roles (.swSectionTitle / .swCardTitle / .swBody / .swMeta) so cards, buttons, and rows can stop reinventing local conventions. - SWViewExtension: design tokens, .swCardStyle / .swAccentCardStyle, swPrimary / swSecondary buttons now reference tokens by default - HomeView: skillsCard and ModuleCard adopt swCardStyle; linksRow softened; hero copy compressed; 4th module renamed Component → Toolkit - ChatView: AI bubble + ComponentPreview + thinking indicator unified via swCardStyle / SWRadius.large - ListItem: rewritten as tinted-icon row primitive with optional color, used unchanged across ComponentView callsites - SettingView: legal links use arrow.up.right; Delete Account drops double-emphasis; API key row aligned to body monospaced + middle truncation; recommended apps split into name + tagline curated rows - RootTabView: tab label Component → Components; ComponentView: row title Setting → Settings - CLAUDE.md: new Visual System section documenting the tokens and the surface/button/typography rules Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SWSpacing/SWRadiusenums and aFontextension (.swSectionTitle/.swCardTitle/.swBody/.swMeta) as a single source of truth for the showcase app's visual languageHomeView,ChatView,ListItem, andSettingViewto the sharedswCardStyle/swAccentCardStylesurface system; replace inlinesecondarySystemGroupedBackground+ hand-rolled strokesarrow.up.right(external-link affordance), Delete Account stops double-emphasizing red, API key row aligned to body monospaced with middle truncation, recommended apps become a curated name + tagline listComponent→Componentstab,Setting→SettingsrowCLAUDE.mdnow has a "Visual System" section so future contributions can reach for the tokens instead of inventing local conventionsTest plan
🤖 Generated with Claude Code