merge queue: embarking unstable (398efc3) and #9322 together#9324
Closed
mergify[bot] wants to merge 6 commits into
Closed
merge queue: embarking unstable (398efc3) and #9322 together#9324mergify[bot] wants to merge 6 commits into
mergify[bot] wants to merge 6 commits into
Conversation
Wire the beacon processor (Work::RpcEnvelope queue + dispatcher), SyncRequestId::SinglePayloadEnvelope, BlockProcessType::SinglePayloadEnvelope, SyncMessage::RpcPayloadEnvelope, router dispatch for PayloadEnvelopesByRoot responses, send_lookup_envelope work-spawn, and the new PayloadEnvelopesByRoot request module. Processing/state-machine logic is stubbed with TODO(gloas) markers; this is plumbing only so the lookup sync rewrite from #9155 can land additively on top.
- payload_envelopes_by_root_requests ActiveRequests field, plumbed through peer_disconnected and active_request_count_by_peer. - payload_lookup_request, on_single_payload_envelope_response, send_payload_for_processing, and a spec() helper. - Re-export PayloadEnvelopesByRootSingleRequest. Drive-by: drop stale `rpc_blob_queue` comment on Work::RpcEnvelope (separate queue is used) and collapse the PayloadEnvelopesByRoot router match to a single ok-case with default error arm.
- manager: on_single_payload_envelope_response now calls into network_context to drive ActiveRequests bookkeeping + per-chunk verification; TODO marks the missing block_lookups dispatch. - sync_methods: process_lookup_envelope mirrors process_lookup_block — chain.verify_envelope_for_gossip + chain.process_execution_payload_envelope with BlockImportSource::Lookup, folding EnvelopeError through BlockError::InternalError until the structured classifier lands with the state machine. - router: drop the low-signal trace! on PayloadEnvelopesByRoot. - Drop now-stale #[allow(dead_code)] / unused_imports gates on the request module and on on_single_payload_envelope_response.
The PR's callers live in the lookup state machine we deliberately didn't copy; nothing in the present scaffold uses it.
It's reached transitively via send_lookup_envelope, which itself is reached by send_payload_for_processing (the actual topmost dead node). One allow at the top of the chain is enough.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch unstable (398efc3) and #9322 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #9322.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:#approved-reviews-by >= 1[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]check-success=local-testnet-successcheck-success=test-suite-successRequired conditions to stay in the queue:
#approved-reviews-by >= 1#approved-reviews-by >= 1[🛡 GitHub branch protection]#changes-requested-reviews-by = 0[🛡 GitHub branch protection]check-success=license/clacheck-success=target-branch-checklabel!=do-not-merge