Skip to content

Add POST beacon/bid endpoint#9347

Merged
mergify[bot] merged 6 commits into
sigp:unstablefrom
eserilev:gloas-post-bid-api
Jun 1, 2026
Merged

Add POST beacon/bid endpoint#9347
mergify[bot] merged 6 commits into
sigp:unstablefrom
eserilev:gloas-post-bid-api

Conversation

@eserilev
Copy link
Copy Markdown
Member

Issue Addressed

This endpoint is needed for buildoor (and eventually our builder client once its implemented)

@michaelsproul michaelsproul requested a review from chong-he May 24, 2026 23:40
@eserilev eserilev added the ready-for-review The code is ready for review label May 25, 2026
Copy link
Copy Markdown
Member

@chong-he chong-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just some minor comments, mostly cosmetics.

Comment thread beacon_node/http_api/src/beacon/execution_payload_bid.rs
Comment thread beacon_node/http_api/src/beacon/bid.rs Outdated
Comment thread beacon_node/http_api/tests/tests.rs Outdated
Comment thread beacon_node/http_api/tests/tests.rs Outdated
@chong-he chong-he added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels May 26, 2026
@eserilev eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels May 28, 2026
Comment thread common/eth2/src/lib.rs Outdated
Comment thread beacon_node/http_api/tests/tests.rs Outdated
Copy link
Copy Markdown
Member

@chong-he chong-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now!

@eserilev eserilev added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels May 30, 2026
@mergify mergify Bot added the queued label May 30, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented May 30, 2026

Merge Queue Status

This pull request spent 21 minutes 39 seconds in the queue, including 19 minutes 35 seconds running CI.

Waiting for
  • check-success=local-testnet-success
  • check-success=test-suite-success
All conditions

Reason

The merge conditions cannot be satisfied due to failing checks

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify Bot added a commit that referenced this pull request May 30, 2026
@mergify mergify Bot added dequeued and removed queued labels May 30, 2026
@eserilev
Copy link
Copy Markdown
Member Author

eserilev commented Jun 1, 2026

@mergify requeue

@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 1, 2026

Merge Queue Status

This pull request spent 25 minutes 7 seconds in the queue, including 22 minutes 8 seconds running CI.

Waiting for
  • check-success=local-testnet-success
  • check-success=test-suite-success
All conditions

Reason

The merge conditions cannot be satisfied due to failing checks

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

@mergify mergify Bot added queued and removed dequeued labels Jun 1, 2026
mergify Bot added a commit that referenced this pull request Jun 1, 2026
@mergify mergify Bot added dequeued and removed queued labels Jun 1, 2026
@eserilev
Copy link
Copy Markdown
Member Author

eserilev commented Jun 1, 2026

@mergify requeue

@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 1, 2026

requeue

🛑 The pull request has been removed from the queue default

Details

The pull request #9347 has been manually updated.

You can take a look at Mergify Merge Queue check runs for more details about the failure.

@mergify mergify Bot removed the dequeued label Jun 1, 2026
@eserilev
Copy link
Copy Markdown
Member Author

eserilev commented Jun 1, 2026

@mergify requeue

@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 1, 2026

Merge Queue Status

This pull request spent 29 minutes 18 seconds in the queue, including 27 minutes 34 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Jun 1, 2026
mergify Bot added a commit that referenced this pull request Jun 1, 2026
@mergify mergify Bot merged commit 578b6a6 into sigp:unstable Jun 1, 2026
37 checks passed
@mergify mergify Bot removed the queued label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gloas HTTP-API ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants