Add gossip validation spec tests for beacon block#9372
Open
jimmygchen wants to merge 11 commits into
Open
Conversation
Extend the generic networking gossip_validation runner with `beacon_block` support. Leave known production outcome mismatches skipped for a later behavior-change commit.
jimmygchen
added
test improvement
jimmygchen
commented
May 29, 2026
| "gossip_block_mid", | ||
| ); | ||
| return None; | ||
| (None, MessageAcceptance::Ignore) |
Member
Author
There was a problem hiding this comment.
Behaviour change here - we are currently not propagating gossip validation results on some of these error match arms
jimmygchen
commented
May 29, 2026
| let block_slot = verified_block.block.slot(); | ||
| let block_root = verified_block.block_root; | ||
| if let Some(verified_block) = verified_block_opt { | ||
| metrics::inc_counter(&metrics::BEACON_PROCESSOR_GOSSIP_BLOCK_VERIFIED_TOTAL); |
Member
Author
There was a problem hiding this comment.
section below is just whitespace change and can be ignored on github
jimmygchen
commented
May 29, 2026
jimmygchen
added
ready-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Addresses #9232 partially. This PR covers the
beacon_blocktopic test vectors.The vectors provide a
state.ssz_snappy, a set of blocks and gossip messages with expected outcomes.The gossip block validation depends on many beacon chain components, so to keep the test close to produciton behaviour,
BeaconChainHarnessis used and we pass the gossip messages through thegossip_methods.rsfunctions.Proposed Changes
MessageAcceptance, so the EF tests can assert the gossip result.AI Assistance Disclosure
Tools used (required — write
noneif no AI was used): codex for the test boilerplate. Rewrote most of the production changes manually.Attestation (required):
Additional Info
I still need to review the test setup more carefully in
builder.rs&gossip_validation.rs.There's also some failing tests which expose an existing mismatch for
gossip_beacon_block__ignore_parent_execution_verified_invalid: the vector expectsIGNORE, while Lighthouse currently returnsREJECTforParentExecutionPayloadInvalid.