Use correct slot in custody request#9380
Merged
Merged
Conversation
jimmygchen
added
ready-for-merge
Merge Queue Status
This pull request spent 31 minutes 3 seconds in the queue, including 28 minutes 48 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the block's slot directly into
custody_lookup_requestinstead of resolving it via a fork-choice lookup (which can fail or return a stale slot for a block not yet in fork choice).This is probably some legacy code from Fulu development, and can lead to incorrect CGC computation and a broken DB. Found this while working on #9155 but we should fix this independently