Skip to content

Add IPC support. - #1

Closed
simonmichal wants to merge 1 commit into
sigp:mainfrom
simonmichal:issue-7336
Closed

Add IPC support.#1
simonmichal wants to merge 1 commit into
sigp:mainfrom
simonmichal:issue-7336

Conversation

@simonmichal

Copy link
Copy Markdown

This PR allows to create SensitiveUrl for an IPC url, i.e.: ipc:///path/to/socket.

@simonmichal

Copy link
Copy Markdown
Author

@michaelsproul for vis

@macladson macladson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for the PR!
I think rather than making an exception for ipc in particular we should support any uncredentialed URL more generally (so we can also support, file://, data/, etc)

I'm in the process of an implementation for that, I'll ping you once it is ready

@michaelsproul

Copy link
Copy Markdown
Member

Closing in favour of:

Thanks for the contribution though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants