feat: add support for signing OCI image manifests#623
feat: add support for signing OCI image manifests#623SequeI wants to merge 2 commits intosigstore:mainfrom
Conversation
Add --oci-manifest flag to sign and verify commands to treat the input as an OCI image manifest JSON file (e.g., from skopeo inspect --raw). This enables signing container images without requiring model files on disk. New functions: - hashing.parse_digest_string(): Parse OCI digest strings - hashing.create_manifest_from_oci_layers(): Create manifest from OCI layers - signing.Config.sign_manifest(): Sign a pre-built manifest - verifying.Config.verify_manifest(): Verify against a pre-built manifest Signed-off-by: SequeI <asiek@redhat.com>
Signed-off-by: SequeI <asiek@redhat.com>
|
I'm a little bit wary of this. All model hubs treat the model as the individual set of files, not the files within the container. I am thinking that a solution that is composable is better, rather than getting into a single-tool-that-supports-all-possible-combinations approach. Sure, I'd propose to discuss this PR in the next model signing SIG meeting, together with the entire plan (as this is just the first part in this work). I'm also CC'ing @Hayden-IO from the Sigstore community's point of view here. |
|
I'll echo Mihai's comments - Cosign is hard to maintain because it does so much. What I'd like to see for Sigstore tooling and clients is a core set of SDKs that are building blocks for signing other artifacts. For files/binaries/blobs, a simple tool that wraps an SDK is sufficient (or a light version of Cosign). Tools like Cosign, Gitsign and model-signing know how to canonicalize a more complex artifact into a bytestream to then be signed and verified by an SDK. I guess the ask is why do we need another implementation of container signing when Cosign already exists? |
Summary
Add --oci-manifest flag to sign and verify commands to treat the input
as an OCI image manifest JSON file (e.g., from skopeo inspect --raw).
This enables signing container images without requiring model files
on disk.
New functions:
Part 1 of supporting OCI model image signing and verifying via ORAS package.
Checklist