Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,11 @@ jobs:
fail-fast: false
matrix:
php:
- "7.2"
- "7.3"
- "7.4"
- "8.0"
- "8.1"
- "8.2"
- "8.3"
- "8.4"
- "8.5"
dependencies:
- "psr/container:^1.1"
- "psr/container:^2.0"
Expand Down Expand Up @@ -46,4 +44,4 @@ jobs:
composer update --prefer-dist --no-progress

- name: Run PHPUnit tests
run: vendor/bin/simple-phpunit --verbose
run: vendor/bin/phpunit
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"psr/container": "^1.1 || ^2.0"
},
"require-dev": {
"symfony/phpunit-bridge": "^5.4@dev"
"phpunit/phpunit": "*"
},
"autoload": {
"psr-0": { "Pimple": "src/" }
Expand Down
4 changes: 0 additions & 4 deletions phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,4 @@
<directory>./src/Pimple/Tests</directory>
</testsuite>
</testsuites>

<listeners>
<listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" />
</listeners>
</phpunit>
19 changes: 16 additions & 3 deletions src/Pimple/Tests/PimpleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

namespace Pimple\Tests;

use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\TestCase;
use Pimple\Container;

Expand Down Expand Up @@ -150,6 +151,7 @@ public function testUnset()
/**
* @dataProvider serviceDefinitionProvider
*/
#[DataProvider('serviceDefinitionProvider')]
public function testShare($service)
{
$pimple = new Container();
Expand All @@ -167,6 +169,7 @@ public function testShare($service)
/**
* @dataProvider serviceDefinitionProvider
*/
#[DataProvider('serviceDefinitionProvider')]
public function testProtect($service)
{
$pimple = new Container();
Expand Down Expand Up @@ -228,6 +231,7 @@ public function testLegacyRawValidatesKeyIsPresent()
/**
* @dataProvider serviceDefinitionProvider
*/
#[DataProvider('serviceDefinitionProvider')]
public function testExtend($service)
{
$pimple = new Container();
Expand Down Expand Up @@ -332,6 +336,7 @@ public function settingNonInvokableObjectShouldTreatItAsParameter()
/**
* @dataProvider badServiceDefinitionProvider
*/
#[DataProvider('badServiceDefinitionProvider')]
public function testFactoryFailsForInvalidServiceDefinitions($service)
{
$this->expectException(\Pimple\Exception\ExpectedInvokableException::class);
Expand All @@ -345,6 +350,7 @@ public function testFactoryFailsForInvalidServiceDefinitions($service)
* @group legacy
* @dataProvider badServiceDefinitionProvider
*/
#[DataProvider('badServiceDefinitionProvider')]
public function testLegacyFactoryFailsForInvalidServiceDefinitions($service)
{
$this->expectException(\InvalidArgumentException::class);
Expand All @@ -357,6 +363,7 @@ public function testLegacyFactoryFailsForInvalidServiceDefinitions($service)
/**
* @dataProvider badServiceDefinitionProvider
*/
#[DataProvider('badServiceDefinitionProvider')]
public function testProtectFailsForInvalidServiceDefinitions($service)
{
$this->expectException(\Pimple\Exception\ExpectedInvokableException::class);
Expand All @@ -370,6 +377,7 @@ public function testProtectFailsForInvalidServiceDefinitions($service)
* @group legacy
* @dataProvider badServiceDefinitionProvider
*/
#[DataProvider('badServiceDefinitionProvider')]
public function testLegacyProtectFailsForInvalidServiceDefinitions($service)
{
$this->expectException(\InvalidArgumentException::class);
Expand All @@ -382,6 +390,7 @@ public function testLegacyProtectFailsForInvalidServiceDefinitions($service)
/**
* @dataProvider badServiceDefinitionProvider
*/
#[DataProvider('badServiceDefinitionProvider')]
public function testExtendFailsForKeysNotContainingServiceDefinitions($service)
{
$this->expectException(\Pimple\Exception\InvalidServiceIdentifierException::class);
Expand All @@ -397,6 +406,7 @@ public function testExtendFailsForKeysNotContainingServiceDefinitions($service)
* @group legacy
* @dataProvider badServiceDefinitionProvider
*/
#[DataProvider('badServiceDefinitionProvider')]
public function testLegacyExtendFailsForKeysNotContainingServiceDefinitions($service)
{
$this->expectException(\InvalidArgumentException::class);
Expand All @@ -412,7 +422,8 @@ public function testLegacyExtendFailsForKeysNotContainingServiceDefinitions($ser
* @group legacy
* @expectedDeprecation How Pimple behaves when extending protected closures will be fixed in Pimple 4. Are you sure "foo" should be protected?
*/
public function testExtendingProtectedClosureDeprecation()
#[DataProvider('badServiceDefinitionProvider')]
public function testExtendingProtectedClosureDeprecation($service)
{
$pimple = new Container();
$pimple['foo'] = $pimple->protect(function () {
Expand All @@ -429,6 +440,7 @@ public function testExtendingProtectedClosureDeprecation()
/**
* @dataProvider badServiceDefinitionProvider
*/
#[DataProvider('badServiceDefinitionProvider')]
public function testExtendFailsForInvalidServiceDefinitions($service)
{
$this->expectException(\Pimple\Exception\ExpectedInvokableException::class);
Expand All @@ -444,6 +456,7 @@ public function testExtendFailsForInvalidServiceDefinitions($service)
* @group legacy
* @dataProvider badServiceDefinitionProvider
*/
#[DataProvider('badServiceDefinitionProvider')]
public function testLegacyExtendFailsForInvalidServiceDefinitions($service)
{
$this->expectException(\InvalidArgumentException::class);
Expand Down Expand Up @@ -488,7 +501,7 @@ public function testExtendFailsIfFrozenServiceIsInvokable()
/**
* Provider for invalid service definitions.
*/
public function badServiceDefinitionProvider()
public static function badServiceDefinitionProvider()
{
return [
[123],
Expand All @@ -499,7 +512,7 @@ public function badServiceDefinitionProvider()
/**
* Provider for service definitions.
*/
public function serviceDefinitionProvider()
public static function serviceDefinitionProvider()
{
return [
[function ($value) {
Expand Down