upgrade to Symfony 4

[alcalyn]

See issue #131

It allows to use web profiler with Symfony 4.

It introduce breaking changes while upgrading to sf4, so I couldn't keep retro-compatibility to SF < 4 for this new version.

[alcalyn]

I don't know how to fix the error in Travis TypeError: Argument 2 passed to Symfony\Component\Security\Http\Firewall\ContextListener::__construct() must be an instance of Symfony\Component\Security\Http\Firewall\iterable, array given. Is it possible to make it work for both PHP 7.1 and hhvm ?

[GregOriol]

@alcalyn Remove hhvm and add php7.2 to match Silex's test configuration (https://github.com/silexphp/Silex/blob/master/.travis.yml)

[alcalyn]

I agree, removed hhvm and added php 7.2.
I'm not sure if removing hhvm is ok for all of you, so let me know how to make tests green with hhvm.

[GregOriol]

@alcalyn It seems that it now fails because of some new deprecations in symfony 4.1 (just released).

[fabpot]

Removing HHVM is a good idea. I've dropped support in all my projects.

[alcalyn]

Ok, good. Errors in unit tests are related to all vendors (HTTPKernel, Twig...) that still use $request->getSession() when no session has been set.

Calling "Symfony\Component\HttpFoundation\Request::getSession()" when no session has been set is deprecated since Symfony 4.1 and will throw an exception in 5.0. Use "hasSession()" instead.

[GregOriol]

@alcalyn Indeed, and I submitted a PR to symfony to fix them (symfony/symfony#27458)

[alcalyn]

Nice @GregOriol, I tried your fix and it makes tests green, so this PR is waiting for symfony/symfony#27458

[GregOriol]

By the way, why not update "symfony/phpunit-bridge" to ^4.0 too? and maybe try to remove the conflict declaration from composer.json?

[alcalyn]

Yep, done

[GregOriol]

@alcalyn Now that symfony 4.1.1 has been released, could you re-check this?

[alcalyn]

Hello, I allow phpunit 6 to be installed to make simple-phpunit tests green.

It's ok for me

[shamotj]

+1 for merge. This is last package which is stopping us from using symfony 4 components.

[jlayt]

+1 for merge and release so we can reach the promised land :-)