fix: BL-15923 e2e tests and temp fix for BL-15919#137
Conversation
|
working on devin review comments |
76c4885 to
b66157d
Compare
b66157d to
2a7b278
Compare
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 8 files and all commit messages.
Reviewable status: 8 of 20 files reviewed, all discussions resolved.
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk reviewed 12 files and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on nabalone).
components/language-chooser/react/common/language-chooser-react-hook/useLanguageChooser.ts line 145 at r1 (raw file):
// that will definitely show that selected language in the results searchString = searchString || initialSelections?.language?.languageSubtag; onSearchStringChange(searchString || "");
Correct me if I'm wrong, but this seems to represent a UX change from the current experience.
I think that's fine. But it should be called out in the card for testing.
nabalone
left a comment
There was a problem hiding this comment.
@nabalone made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on andrew-polk).
components/language-chooser/react/common/language-chooser-react-hook/useLanguageChooser.ts line 145 at r1 (raw file):
Previously, andrew-polk wrote…
Correct me if I'm wrong, but this seems to represent a UX change from the current experience.
I think that's fine. But it should be called out in the card for testing.
This should not be a behavior change for Bloom; there we already passing the language tag in as the searchString; this should basically be equivalent: https://github.com/BloomBooks/BloomDesktop/blob/master/src/BloomBrowserUI/collection/LanguageChooserDialog.tsx#L148
I just did this change to make testing and demoing easier
andrew-polk
left a comment
There was a problem hiding this comment.
@andrew-polk resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on nabalone).
This change is