Skip to content

fix: BL-15923 e2e tests and temp fix for BL-15919#137

Merged
andrew-polk merged 1 commit intomainfrom
BL-15923_more_e2e_tests
Feb 23, 2026
Merged

fix: BL-15923 e2e tests and temp fix for BL-15919#137
andrew-polk merged 1 commit intomainfrom
BL-15923_more_e2e_tests

Conversation

@nabalone
Copy link
Collaborator

@nabalone nabalone commented Feb 19, 2026

This change is Reviewable

@nabalone
Copy link
Collaborator Author

working on devin review comments

@nabalone nabalone force-pushed the BL-15923_more_e2e_tests branch 2 times, most recently from 76c4885 to b66157d Compare February 19, 2026 23:29
@nabalone nabalone force-pushed the BL-15923_more_e2e_tests branch from b66157d to 2a7b278 Compare February 19, 2026 23:40
Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk reviewed 8 files and all commit messages.
Reviewable status: 8 of 20 files reviewed, all discussions resolved.

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk reviewed 12 files and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on nabalone).


components/language-chooser/react/common/language-chooser-react-hook/useLanguageChooser.ts line 145 at r1 (raw file):

    // that will definitely show that selected language in the results
    searchString = searchString || initialSelections?.language?.languageSubtag;
    onSearchStringChange(searchString || "");

Correct me if I'm wrong, but this seems to represent a UX change from the current experience.
I think that's fine. But it should be called out in the card for testing.

Copy link
Collaborator Author

@nabalone nabalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabalone made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on andrew-polk).


components/language-chooser/react/common/language-chooser-react-hook/useLanguageChooser.ts line 145 at r1 (raw file):

Previously, andrew-polk wrote…

Correct me if I'm wrong, but this seems to represent a UX change from the current experience.
I think that's fine. But it should be called out in the card for testing.

This should not be a behavior change for Bloom; there we already passing the language tag in as the searchString; this should basically be equivalent: https://github.com/BloomBooks/BloomDesktop/blob/master/src/BloomBrowserUI/collection/LanguageChooserDialog.tsx#L148

I just did this change to make testing and demoing easier

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on nabalone).

@andrew-polk andrew-polk merged commit afc8673 into main Feb 23, 2026
2 checks passed
@andrew-polk andrew-polk deleted the BL-15923_more_e2e_tests branch February 23, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants