Conversation
* Add classified dictionary word export option. * Extend guideword handling to allow for multiple run styles included in a single guideword. Change-Id: I4b1a4305f66e5bea49ff52183dfbd41f25ac02b6
* Add test for guideword styles for classified dictionary * Update test for guideword styles for configured dictionary * Fix GetFirstGuidewordStylesList in WordGenerator to get at most one primary style and one beforeafterbetween style Change-Id: Ia270e5e2a5199ba3f7c64dc8771b6bac9d70f778
NUnit Tests 1 files ±0 1 suites ±0 11m 19s ⏱️ -18s Results for commit 4cb2bf9. ± Comparison against base commit 3114dfe. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. |
mark-sil
requested changes
May 28, 2026
Contributor
mark-sil
left a comment
mark-sil
left a comment
There was a problem hiding this comment.
@mark-sil reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on aror92).
Src/xWorks/DictionaryExportService.cs line 116 at r1 (raw file):
} public void ExportWordClassifiedDictionary(string filePath, int[] entriesToSave, RecordClerk clerk,
When you call this method, you pass in "domainsToSave", which I think makes more sense than "entriesToSave". To avoid confusion should you change it here to "domainsToSave"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add classified dictionary word export option.
Extend guideword handling to allow for multiple run styles included in a single guideword.
Add test for guideword styles for classified dictionary
Update test for guideword styles for configured dictionary
This change is