Conversation
NUnit Tests 1 files ±0 1 suites ±0 10m 38s ⏱️ - 1m 0s Results for commit 1c5d86c. ± Comparison against base commit dc4ed22. This pull request removes 2 and adds 5 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
To keep the Word display the same as the display in Flex: If there is Between text, then we should not also add the Before text.
Render comparison artifactsRender snapshot failures were reported in b3352bbd34c8 run 26586560583.1, but the latest run b3352bbd34c8 run 26586560583.2 is clean. This comment will be replaced if a future run produces render snapshot failures again. |
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 6 files and all commit messages, and made 3 comments.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on mark-sil).
Src/xWorks/ConfiguredLcmGenerator.cs line 1744 at r1 (raw file):
typeNode = null; // Generate XHTML by Type bool outerFirst = true;
firstType
Code quote:
outerFirstSrc/xWorks/ConfiguredLcmGenerator.cs line 1748 at r1 (raw file):
{ var combinedContent = settings.ContentGenerator.CreateFragment(); bool innerFirst = true;
firstRef
Code quote:
innerFirst
This change is