Skip to content

LT-22517: Word Export: Add between text to variant types#917

Open
mark-sil wants to merge 2 commits into
mainfrom
LT-22517
Open

LT-22517: Word Export: Add between text to variant types#917
mark-sil wants to merge 2 commits into
mainfrom
LT-22517

Conversation

@mark-sil
Copy link
Copy Markdown
Contributor

@mark-sil mark-sil commented May 27, 2026

This change is Reviewable

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   10m 38s ⏱️ - 1m 0s
4 209 tests +3  4 139 ✅ +3  70 💤 ±0  0 ❌ ±0 
4 218 runs  +3  4 148 ✅ +3  70 💤 ±0  0 ❌ ±0 

Results for commit 1c5d86c. ± Comparison against base commit dc4ed22.

This pull request removes 2 and adds 5 tests. Note that renamed tests count towards both.
SIL.FieldWorks.XWorks.LcmWordGeneratorTests ‑ GenerateBeforeBetweenAfterContent
SIL.FieldWorks.XWorks.LcmWordGeneratorTests ‑ GenerateBeforeBetweenAfterContentWithWSAbbreviation
SIL.FieldWorks.XWorks.LcmWordGeneratorTests ‑ BeforeBetweenAfterContent
SIL.FieldWorks.XWorks.LcmWordGeneratorTests ‑ BeforeBetweenAfterContentWithWSAbbreviation
SIL.FieldWorks.XWorks.LcmWordGeneratorTests ‑ BeforeContentSuppressedOnSubsequentVariantTypeGroupsWhenBetweenPresent
SIL.FieldWorks.XWorks.LcmWordGeneratorTests ‑ BetweenContentAbsentForSingleVariantTypeGroup
SIL.FieldWorks.XWorks.LcmWordGeneratorTests ‑ BetweenContentOnceForMultipleVariantTypesGroups

♻️ This comment has been updated with latest results.

@mark-sil mark-sil marked this pull request as draft May 27, 2026 20:32
To keep the Word display the same as the display in Flex:
If there is Between text, then we should not also add the Before
text.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2026

Render comparison artifacts

Render snapshot failures were reported in b3352bbd34c8 run 26586560583.1, but the latest run b3352bbd34c8 run 26586560583.2 is clean.

This comment will be replaced if a future run produces render snapshot failures again.

@mark-sil mark-sil marked this pull request as ready for review May 28, 2026 16:28
Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 6 files and all commit messages, and made 3 comments.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on mark-sil).


Src/xWorks/ConfiguredLcmGenerator.cs line 1744 at r1 (raw file):

				typeNode = null;
			// Generate XHTML by Type
			bool outerFirst = true;

firstType

Code quote:

outerFirst

Src/xWorks/ConfiguredLcmGenerator.cs line 1748 at r1 (raw file):

			{
				var combinedContent = settings.ContentGenerator.CreateFragment();
				bool innerFirst = true;

firstRef

Code quote:

innerFirst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants