Skip to content

[gha] Add missing Docker build endpoint#4285

Merged
imnasnainaec merged 2 commits into
masterfrom
gha-frontend-build-endpoint
May 20, 2026
Merged

[gha] Add missing Docker build endpoint#4285
imnasnainaec merged 2 commits into
masterfrom
gha-frontend-build-endpoint

Conversation

@imnasnainaec
Copy link
Copy Markdown
Collaborator

@imnasnainaec imnasnainaec commented May 19, 2026

Fixing (e.g.):

This change is Reviewable

Summary by CodeRabbit

  • Chores
    • Updated build pipeline configuration to enhance security and reliability.

Review Change Stack

@imnasnainaec imnasnainaec self-assigned this May 19, 2026
@imnasnainaec imnasnainaec added the 🟥High High-priority PR: please review this asap! label May 19, 2026
@github-actions github-actions Bot added the github_actions Pull requests that update GitHub Actions code label May 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

📝 Walkthrough

Walkthrough

This PR adds the CloudFront endpoint production.cloudfront.docker.com:443 to the Harden Runner egress allowlist for the docker_build job in the frontend CI workflow, enabling Docker image pulls during the build process.

Changes

Docker build security policy

Layer / File(s) Summary
Harden Runner egress policy update
.github/workflows/frontend.yml
The allowed-endpoints list in the Harden Runner configuration for the docker_build job is expanded to allow outbound connections to production.cloudfront.docker.com:443 for Docker image pulls.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A CloudFront door, we now unlock,
Docker pulls faster, tick by tock,
One endpoint added, security's tight,
The build pipeline shines so bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main change: adding a missing Docker build endpoint to the GitHub Actions workflow configuration.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gha-frontend-build-endpoint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/frontend.yml:
- Line 144: Remove the invalid allowlist entry
"production.cloudfront.docker.com:443" from the egress host list in the
workflow; it's a typo/misconfiguration—ensure the correct entry
"production.cloudflare.docker.com" remains and do not add the CloudFront variant
anywhere in the list.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 95c0ab32-bb95-40a9-9fb6-d07ac9dcb315

📥 Commits

Reviewing files that changed from the base of the PR and between faf925c and 829995d.

📒 Files selected for processing (1)
  • .github/workflows/frontend.yml

Comment thread .github/workflows/frontend.yml
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.93%. Comparing base (faf925c) to head (9107f05).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4285   +/-   ##
=======================================
  Coverage   75.93%   75.93%           
=======================================
  Files         303      303           
  Lines       11352    11352           
  Branches     1404     1404           
=======================================
  Hits         8620     8620           
  Misses       2330     2330           
  Partials      402      402           
Flag Coverage Δ
backend 87.21% <ø> (ø)
frontend 66.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec imnasnainaec changed the title [gha] Add missing frontend Docker build endpoint [gha] Add missing Docker build endpoint May 19, 2026
Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

@imnasnainaec imnasnainaec merged commit ebb4232 into master May 20, 2026
20 checks passed
@imnasnainaec imnasnainaec deleted the gha-frontend-build-endpoint branch May 20, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code 🟥High High-priority PR: please review this asap!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants