Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes waveform UX regressions during audio editing by preserving the user’s current playhead position and zoom level across edit-triggered reloads, so the waveform doesn’t jump back to the start or reset to fit-to-width.
Changes:
- Restore the current playhead position after undo by reloading the audio at the current progress time.
- Prevent automatic zoom “snap back” to fit-to-width after snip/undo by preserving and re-applying the prior zoom.
- Adjust zoom-min synchronization so
fillPxchanges only raise zoom when the current zoom is below the new minimum.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/renderer/src/crud/useWaveSurfer.tsx | Undo reload now restores the current position (via progress()), relying on existing clamping behavior in wsGoto. |
| src/renderer/src/components/WSAudioPlayerZoom.tsx | Keeps user zoom when fillPx changes unless current zoom falls below the new minimum. |
| src/renderer/src/components/WSAudioPlayer.tsx | Preserves zoom across edit reloads (snip/undo) and re-applies it on WS ready when appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.