Conversation
josephmyers
approved these changes
Feb 20, 2025
Collaborator
josephmyers
left a comment
There was a problem hiding this comment.
Code looks good to me. Just a small question/comment
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewed 3 of 5 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @hahn-kev and @josephmyers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the package System.Diagnostics.DiagnosticSource supports all the way back to net462 and lets use configure some distributed tracing which can then be instrumented by our applications. After tracing our sync code in Lexbox, I would like to get a little more insight into what's going on in chorus. I've trace the following:
Tracing is similar to logging so that when no one is listening to the activity source then no activity will be created and it'll be a noop for the code in question. In order to listen to those events with OTEL, you can do something like
service.AddOpenTelemetry().WithTracing(b => b.AddSource(LibChorusActivitySource.ActivitySourceName));then all the activities configured in this PR will be emit traces and logged in OTEL. I suspect other application tracing frameworks would also tap in to these traces. It could also be used for analytics.
This change is