Prevent creating objects with duplicated GUIDs#367
Merged
Conversation
rmunn
commented
Feb 12, 2026
rmunn
force-pushed
the
bug/prevent-dupe-guid-creation
branch
from
d493349 to
12f0af4
Compare
Contributor
Author
|
Don't know why publish-test-results is failing. Will close and reopen the PR in order to kick it anew, and perhaps that will get GHA unstuck? |
Contributor
Author
|
Apparently all PRs are having issues with permission being denied to the publish-test-results step. |
TryGetObject would create and populate an object, but here we only want to check whether the GUID we're trying to use is already assigned. So we just use the IsValidObjectId() method, which only returns a bool. We just have to document that here, we want the method to return *false*.
myieye
approved these changes
Feb 13, 2026
Contributor
myieye
left a comment
myieye
left a comment
There was a problem hiding this comment.
I added some tests and changed the exception message, because it's not scoped by class.
papeh
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #365.
This should not affect FW, since the
FooFactory.Create(guid)method is not used in FieldWorks. FW Lite uses it, so that FW Lite can create LCM objects with GUIDs that match the GUIDs of objects that are being synchronized from other projects. And FW Lite will be changed to expect an InvalidOperationError to be thrown in case of a duplicated GUID being created, and handle the resulting merge conflict accordingly.This change is