Port: Improve alignment exception error reporting#303
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
==========================================
- Coverage 91.53% 91.50% -0.03%
==========================================
Files 355 355
Lines 23028 23042 +14
==========================================
+ Hits 21079 21085 +6
- Misses 1949 1957 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ddaspit and pmachapman).
machine/corpora/corpora_utils.py line 20 at r1 (raw file):
def alignment_exception(refs: Iterable[str]) -> TypeError: return TypeError( f'Invalid format in {", ".join(refs)}. '
We should make this match the updated message in Machine.
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93).
machine/corpora/corpora_utils.py line 20 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
We should make this match the updated message in Machine.
Agreed. The equivalent of InvalidOperationException for Python would probably be RuntimeError.
ac4f647 to
4b2b05c
Compare
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93).
machine/corpora/corpora_utils.py line 20 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Agreed. The equivalent of
InvalidOperationExceptionfor Python would probably beRuntimeError.
Done.
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
Fixes #283
This change is