Add scale-to-fit option to ptxprint finishing tab and to pdfinish#1172
Add scale-to-fit option to ptxprint finishing tab and to pdfinish#1172simonbray wants to merge 10 commits into
Conversation
|
As far as I can tell booklet pagination wasn't working on the ptxprint finishing tab, was that a known issue? This is my fix: aae6325 |
mhosken
left a comment
There was a problem hiding this comment.
This is wrong. The output pdffile is calculated from the pdffile rather than just being the pdffile. Passing output_filepath will break that calculation.
|
In the last PR the python/scripts/pdfinish was removed. This is necessary for pyinstaller to be able to create an exe for this. So it needs to be put back (simply calls pdfinish.main). Then we can put pdfinish into the distribution again. |
|
pdfinish does the processing before asking the user for the output filename. This is problematic. In addition we want to extend the tool to be able to process multiple files. To head towards that please can we have an output path and selector paralleling the input and then the process button simply does the work rather than asking for an output file. If the output file is missing, the process button can be disabled. |
fixed in 767768a
fixed in 9c33744
the first part is fixed in ed5f192, so processing doesn't begin until the user has selected a file. The second part I'm working on and will make a new PR for. So should be ready to merge 👍 |
TODO: need to activate for ptxprint itself.- done