Skip to content

Add scale-to-fit option to ptxprint finishing tab and to pdfinish#1172

Open
simonbray wants to merge 10 commits into
sillsdev:masterfrom
simonbray:scale-to-fit
Open

Add scale-to-fit option to ptxprint finishing tab and to pdfinish#1172
simonbray wants to merge 10 commits into
sillsdev:masterfrom
simonbray:scale-to-fit

Conversation

@simonbray
Copy link
Copy Markdown
Contributor

@simonbray simonbray commented May 22, 2026

TODO: need to activate for ptxprint itself. - done

@simonbray
Copy link
Copy Markdown
Contributor Author

As far as I can tell booklet pagination wasn't working on the ptxprint finishing tab, was that a known issue?

This is my fix: aae6325

@simonbray simonbray changed the title Add scale-to-fit option to pdfinish Add scale-to-fit option to ptxprint finishing tab and to pdfinish May 25, 2026
Copy link
Copy Markdown
Collaborator

@mhosken mhosken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. The output pdffile is calculated from the pdffile rather than just being the pdffile. Passing output_filepath will break that calculation.

@mhosken
Copy link
Copy Markdown
Collaborator

mhosken commented May 27, 2026

In the last PR the python/scripts/pdfinish was removed. This is necessary for pyinstaller to be able to create an exe for this. So it needs to be put back (simply calls pdfinish.main). Then we can put pdfinish into the distribution again.

@mhosken
Copy link
Copy Markdown
Collaborator

mhosken commented May 27, 2026

pdfinish does the processing before asking the user for the output filename. This is problematic. In addition we want to extend the tool to be able to process multiple files. To head towards that please can we have an output path and selector paralleling the input and then the process button simply does the work rather than asking for an output file. If the output file is missing, the process button can be disabled.

@simonbray
Copy link
Copy Markdown
Contributor Author

In the last PR the python/scripts/pdfinish was removed. This is necessary for pyinstaller to be able to create an exe for this. So it needs to be put back (simply calls pdfinish.main). Then we can put pdfinish into the distribution again.

fixed in 767768a

This is wrong. The output pdffile is calculated from the pdffile rather than just being the pdffile. Passing output_filepath will break that calculation.

fixed in 9c33744

pdfinish does the processing before asking the user for the output filename. This is problematic. In addition we want to extend the tool to be able to process multiple files. To head towards that please can we have an output path and selector paralleling the input and then the process button simply does the work rather than asking for an output file. If the output file is missing, the process button can be disabled.

the first part is fixed in ed5f192, so processing doesn't begin until the user has selected a file. The second part I'm working on and will make a new PR for.

So should be ready to merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants