Skip to content

Add support for per-chapter remarks#934

Merged
Enkidu93 merged 2 commits into
mainfrom
per_chapter_remarks
May 28, 2026
Merged

Add support for per-chapter remarks#934
Enkidu93 merged 2 commits into
mainfrom
per_chapter_remarks

Conversation

@pmachapman
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman commented Apr 29, 2026

Fixes #905.

Requires sillsdev/machine#408.


This change is Reviewable

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 80.45977% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.57%. Comparing base (dc1b0db) to head (22b4865).

Files with missing lines Patch % Lines
...rval.Translation/Services/UsfmGenerationService.cs 80.45% 9 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   65.60%   65.57%   -0.04%     
==========================================
  Files         381      381              
  Lines       21705    21703       -2     
  Branches     2766     2770       +4     
==========================================
- Hits        14239    14231       -8     
- Misses       6433     6437       +4     
- Partials     1033     1035       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmachapman pmachapman requested review from Enkidu93 and ddaspit April 30, 2026 04:43
Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@pmachapman pmachapman force-pushed the per_chapter_remarks branch 2 times, most recently from f055f9e to 0d209e3 Compare May 11, 2026 19:15
Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@pmachapman pmachapman requested a review from ddaspit May 13, 2026 23:12
Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@pmachapman pmachapman force-pushed the per_chapter_remarks branch from 8afba78 to dd2b559 Compare May 19, 2026 00:31
Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

@pmachapman
Copy link
Copy Markdown
Collaborator Author

This PR is currently blocked awaiting feedback from stakeholders.

@pmachapman pmachapman force-pushed the per_chapter_remarks branch from dd2b559 to 22b4865 Compare May 28, 2026 03:06
@pmachapman pmachapman requested a review from ddaspit May 28, 2026 03:08
Copy link
Copy Markdown
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

Copy link
Copy Markdown
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@Enkidu93 Enkidu93 merged commit 20bbbec into main May 28, 2026
2 checks passed
@Enkidu93 Enkidu93 deleted the per_chapter_remarks branch May 28, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add remarks per chapter

4 participants