Change line count warning to error in extract_corpora#1084
Open
TaperChipmunk32 wants to merge 2 commits into
Open
Change line count warning to error in extract_corpora#1084TaperChipmunk32 wants to merge 2 commits into
TaperChipmunk32 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR elevates a warning in
extract_corporato an Exception when the line count is not equal to theexpected_verse_count, which is the length of a full extract. The former warning also only was output when the line_count was greater thanexpected_verse_count, now it will be raised when the line_count is not equal to theexpected_verse_count.This change is