Minor fixes to onboarding management

[Nateowami]

• Fix incorrect obsolete comment
• Update silnlp onboarding flag to --datestamp
• Improve front-end detection of whether a request is resolved
• Fix naming of OnboardingRequestService file

---

This change is 

[Nateowami]

@Nateowami made 2 comments.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions.

---

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/draft-request-detail.component.ts line 223 at r1 (raw file):

  get isResolved(): boolean {
    return this.request?.resolution != null && this.request.resolution !== 'unresolved';

This probably couldn't have caused a bug in the UI, but wasn't quite as precise as it should have been.

---

src/SIL.XForge.Scripture/Controllers/OnboardingRequestRpcController.cs line 352 at r1 (raw file):

    /// Sets the resolution for a drafting signup request.
    /// Only accessible to Serval admins.
    /// If resolution is set to a non-null value, the assignee is cleared.

This is no longer correct as of #3691

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.83%. Comparing base (f070a66) to head (bd1c70e).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3695   +/-   ##
=======================================
  Coverage   81.83%   81.83%           
=======================================
  Files         619      619           
  Lines       38620    38620           
  Branches     6317     6293   -24     
=======================================
  Hits        31603    31603           
  Misses       6056     6056           
  Partials      961      961           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pmachapman]

@pmachapman partially reviewed 6 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Nateowami).