This repository was archived by the owner on Oct 18, 2020. It is now read-only.
Fix a timing attack issue with CSRF token validation.#393
Open
katanacrimson wants to merge 1 commit intosilverwind:masterfrom
katanacrimson:csrf-constant-time-comparison
Open
Fix a timing attack issue with CSRF token validation.#393katanacrimson wants to merge 1 commit intosilverwind:masterfrom katanacrimson:csrf-constant-time-comparison
katanacrimson wants to merge 1 commit intosilverwind:masterfrom
katanacrimson:csrf-constant-time-comparison
Conversation
crypto.timingSafeEqual (a constant-time string comparison method) should be used for sensitive comparisons to avoid providing an opening for timing attacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing the lazy string comparison with a constant-time string comparison provided by nodejs's internal crypto module.