Feat/cli add --fail-on-error param to trigger cmd#7
Merged
MorErel merged 1 commit intosimilarweb:masterfrom Sep 21, 2025
Merged
Conversation
Updated `trigger` method to accept failOnError parameter, ensuring given status from waitForBuild isn't treated as error like "FAILURE".
elad-aharon
force-pushed
the
feat/cli_add_expected_statuses_param_to_trigger
branch
from
eeb3a99 to
c04a1b4
Compare
elad-aharon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of PR is this?
Backend Feature
What this PR does / why we need it?
Support expected build statuses for trigger, not only wait for build to finish. Helpful when you need to wait for a success state.
which issue(s) this PR fixes (if exists)
Fixes #(issue)
Special notes for your reviewer
Does this PR introduce a breaking change, if so what is it?
Additional documentation
A picture of my dog Dibble, for luck
