Conversation
simonc
force-pushed
the
windows-support
branch
from
4558c2c to
7824512
Compare
On Windows, File.basename('D:/') returns '/' which caused
Directory#find to fail when stripping the root prefix from paths.
Now root directories preserve their full normalized path (e.g., 'D:/')
as their name, ensuring path.start_with?(name) works correctly.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Normalize glob patterns before matching so '/test' matches 'D:/test' - Fix chroot to use platform_root instead of hardcoded '/' - Fix Directory#find to strip platform root for non-root directories - Update test expectations to use expected_path() for cross-platform support Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Directory#find: strip platform_root first before checking directory name - mktmpdir: normalize the tmpdir argument and returned path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
On Windows, paths like 'D:foo' (without slash after colon) are drive-relative paths. Ruby's File.dirname returns 'D:.' for these, which the fake filesystem couldn't handle. This fix converts: - 'D:' (bare drive) → 'D:/' - 'D:foo' or 'D:.' → 'D:/foo' or 'D:/.' This resolves failures in FileUtils.install tests on Ruby 3.3+ Windows. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
simonc
force-pushed
the
windows-support
branch
from
4876e72 to
d50acc8
Compare
simonc
added a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.