Fix exact filters for numeric computed view columns#2717
Open
Ethan-kkk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2713
This fixes filtering SQLite views by numeric computed columns, such as
SUM(...) AS valid_count, wherevalid_count__exact=0returned no rows even when the view contained rows withvalid_count = 0.URL query parameters are bound as strings, so
valid_count__exact=0binds"0"as text. Regular INTEGER table columns can rely on SQLite affinity for comparison, but computed view columns may have no declared type, so comparing integer0to text"0"does not match.This change passes column details into filter SQL generation. For
exactandnotfilters on columns with no declared type, numeric-looking filter values now include an additional guarded numeric comparison usingtypeof(column) in ('integer', 'real')andCAST(:p AS NUMERIC).The original text comparison is preserved, so text values such as
"00"are not incorrectly matched as numeric0.Tests cover:
valid_count__exact=0on a computed numeric view columnvalid_count__not=0on the same view