Fix quote rendering to use markdown

[simonw]

blog-to-newsletter should render quotes using markdown, they currently look like this which is wrong

[claude]

Claude finished @simonw's task —— View job

---

Pull Request Review

Todo List:

• Read repository guidelines (CLAUDE.md)
• Analyze the modified file and changes
• Review for code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Assess security concerns
• Review test coverage

Code Quality & Best Practices ✅

The changes are well-structured and follow existing patterns:

• Consistent with how blogmarks and notes use marked.parse() for markdown rendering (blog-to-newsletter.html:666, 669)
• Proper JSON object structure in SQL matches the pattern used by other content types
• JavaScript logic follows the existing conditional structure and error handling patterns

Potential Bugs & Issues ✅

No significant issues identified:

• Proper null checking with e.json !== 'null' (blog-to-newsletter.html:676)
• Safe fallback with info.quotation || '' to handle missing content
• Consistent JSON parsing logic matching existing code patterns
• Proper HTML escaping is handled by marked.parse()

Performance Considerations ✅

• Minimal performance impact: only processes quotations that have JSON data
• marked.parse() is already loaded and used elsewhere in the application
• No additional network requests or heavy computations introduced

Security Concerns ✅

• Using marked.parse() which is already trusted throughout the application
• No new XSS vectors introduced - markdown parsing provides built-in sanitization
• No user input directly processed without validation

Test Coverage ⚠️

Limitation identified: No automated test coverage visible for this functionality. The change modifies critical rendering logic but appears to rely on manual testing. Consider adding:

• Unit tests for quotation markdown rendering
• Integration tests for the SQL query changes
• Regression tests to ensure existing quote formatting still works

Overall Assessment

This is a solid improvement that fixes markdown formatting in quotations by:

1. Properly exposing quotation data via JSON in the SQL query
2. Processing quotation content through the same markdown parser used by other content types

The implementation is consistent, safe, and follows existing patterns. The only concern is the lack of automated test coverage for this critical rendering functionality.

Recommendation: ✅ Approve - This is a clean fix that improves functionality without introducing risks.

---

[cloudflare-workers-and-pages]

Deploying tools with    Cloudflare Pages

Latest commit:	ee0979c
Status:	✅  Deploy successful!
Preview URL:	https://9e88bb25.tools-b1q.pages.dev
Branch Preview URL:	https://claude-fix-quote-rendering-k.tools-b1q.pages.dev

View logs

[simonw]

Fixed.