Improve PKCE from_h docs and string-key test#101
Merged
Conversation
Follow-up to #100: document that code_challenge_method is optional and code_challenge is not re-validated in from_h, and add a dedicated test for string-key round-trips. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@notedocumentation toPKCE.from_hclarifying thatcode_challenge_methodis optional (defaults toS256) and thatcode_challengeis not re-validated againstcode_verifierfrom_hare explicitly exercisedFollow-up to #100.
Test plan
bundle exec rspec spec/lib/mcp_client/auth_spec.rb— 17 examples, 0 failures🤖 Generated with Claude Code