fix: preserve case for Ę, Ī, Ķ, Ū in charmap#211
Closed
greymoth-jp wants to merge 1 commit into
Closed
Conversation
These four uppercase letters mapped to lowercase ASCII (e, i, k, u)
while every other uppercase entry maps to uppercase, so slugify lost
the capital, e.g. slugify('Ķīpsala') returned 'kipsala' instead of
'Kipsala'. Map them to E, I, K, U and fix the Polish/Latvian test
tables, which encoded the same typo.
Collaborator
|
Duplicate of #209. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four uppercase letters in
config/charmap.jsonmap to lowercase ASCII, while every other uppercase entry maps to uppercase:Ę(U+0118) waseĪ(U+012A) wasiĶ(U+0136) waskŪ(U+016A) wasuSince
loweris off by default, this drops the capital on transliteration.Āworks butŪdoes not, even though they sit in the same block:The
replace polish charsandreplace latvian charstests carried the same typo. For example the Latvian table had'Ā': 'A'and'Ī': 'i'on the same line.I changed the four values to
E,I,K,U, regeneratedslugify.jswithnpm run build, and fixed those two test tables. The lowercase counterparts (ę,ī,ķ,ū) are unchanged. All 45 tests pass.