Skip to content

fix(Deduplicator): Duplicate Immutable Associations #5763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igbanam merged 1 commit into from
Feb 10, 2026
Merged

fix(Deduplicator): Duplicate Immutable Associations #5763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions app/services/one_off/opensrp/deduplicators/for_immutable_entity.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,30 @@ def initialize old_id, new_id, assoc = nil
end

def merge
old_patient.send(@association).each do |associated|
associated.patient = new_patient
associated.save!
if is_has_many?(@association)
old_patient.send(@association).each do |associated|
new_patient.send(@association) << associated.dup
end
else
old_patient.send(@association).each do |associated|
duplicate = associated.dup
duplicate.patient = new_patient
duplicate.save!
end
end

# return the old patient object for the chain
old_patient
end

private

def is_has_many? assoc
Patient
.reflect_on_all_associations(:has_many)
.map(&:name)
.include?(assoc)
end
end
end
end
Expand Down