Feature/refactor build

[tvdijen]

Closes #109

[tvdijen]

See build: https://github.com/simplesamlphp/SAML-tracer/actions/runs/28720058215
This zip-file looks fine, right? AMO can now check the usual places like composer.json and package.json

[khlr]

Formerly we had this in build.sh which, I think, leads to a much smaller result:
node tools/build.js xml properties http

This highlight.min.js has all grammars included which really boosts the file size. But I guess we'll just have to accept that...

[tvdijen]

I found a way to do this without including the full version with all gramars.

[khlr]

I’m sorry, I didn’t express myself clearly here:
What I wanted to say is - we won't get around using the much larger full min.js. Not for technical reasons, but to be compliant.

Why? Put yourself in the reviewer’s shoes: Well, there's this "highlight.js": "github:highlightjs/highlight.js" line in the package.json, but the resulting file's (node tools/build.js xml properties http) SHA-256 checksum is EDC54457F239E23A9FE14DA9C5ECF5B6B0F703DF385C072D669B8D9D140EA565.

If the reviewer doesn't build this same custom hljs version (what they probably won't do), then there'll never be the same file hash.

Consequently, from the reviewer’s perspective, it will appear as though we are saying we are using the official hljs, but what we are actually delivering is a minified, custom version of hljs, which they cannot really verify.

[tvdijen]

@khlr I think I was able to address all your comments. Both dependencies are now in package.json, which hopefully is acceptable to AMO.
If you agree with this, I think this should be merged and released as 1.9.4.
The step to completely remove pako can then move to a new minor release, unless you think it's an easy fix.

[khlr]

Sorry for the extra effort, @tvdijen.
But I'm pretty sure, they won't accept it with the nice but unverifiable custom hljs build:
#110 (comment)

[tvdijen]

Sorry for the extra effort, @tvdijen. But I'm pretty sure, they won't accept it with the nice but unverifiable custom hljs build: #110 (comment)

Ah sure they can, if we point them in the right direction. We use the official source, and use their build-script to get the minimal required version.
Just one or two sentences explaining this should do.

We should just try, I guess? If they don't, the extra step for building the custom min.js is easy to remove.
Why not try to upload this as 1.9.3, since that one doesn't exist yet for Firefox

I would do it if I knew how.. This change by itself is OK for now, right? (e.g. replacing the build-script with a npm-dependencies in package.json and building in the GH Action.

[khlr]

Version 1.9.4 uploaded (couldn't edit 1.9.3).
Let's see what happens ;)