agent: split SimplexNameDomain out of SimplexNameInfo#1788
Merged
Conversation
The type now separates the user-supplied type prefix (#/@) from the
domain itself:
data SimplexNameInfo = SimplexNameInfo
{ nameType :: SimplexNameType
, nameDomain :: SimplexNameDomain
}
data SimplexNameDomain = SimplexNameDomain
{ nameTLD :: SimplexTLD
, domain :: Text
, subDomain :: [Text]
}
The domain is independent of the contact-vs-public-group distinction —
the same dotted-labels structure applies to both. Future code that
needs to talk about a domain without committing to a name type (e.g.
server-side TLD-based registry lookup) can use SimplexNameDomain
directly.
fullDomainName now operates on SimplexNameDomain rather than the
full info wrapper. Parser, StrEncoding instance, and aeson derivations
updated accordingly. No external callers needed updating.
epoberezkin
reviewed
May 28, 2026
|
|
||
| fullDomainName :: SimplexNameInfo -> Text | ||
| fullDomainName SimplexNameInfo {nameTLD, domain, subDomain} = T.intercalate "." (reverse subDomain ++ [domain] ++ tld') | ||
| [name] -> Right $ SimplexNameDomain TLDSimplex name [] |
Member
There was a problem hiding this comment.
this is not a valid domain, it's only valid as part of channel name
epoberezkin
reviewed
May 28, 2026
| "testing" : name : sub -> Right $ SimplexNameDomain TLDTesting name sub | ||
| _ -> Right $ SimplexNameDomain TLDWeb (T.intercalate "." labels) [] | ||
|
|
||
| instance StrEncoding SimplexNameInfo where |
epoberezkin
reviewed
May 28, 2026
| where | ||
| infoP NTContact = do | ||
| bs <- lookAhead $ A.takeWhile1 (not . A.isSpace) | ||
| unless (B.elem '.' bs) $ fail "contact name requires TLD" |
Member
There was a problem hiding this comment.
it should be the opposite. Not contact is more restrictive, but channel should be more permissive than domain parser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.