Skip to content

port-allow-service: try connect to online devices on suspended nodes #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hamdy-khader wants to merge 1 commit into
base: main
Choose a base branch
from
Open

port-allow-service: try connect to online devices on suspended nodes #1011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion simplyblock_core/services/tasks_runner_port_allow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def exec_port_allow_task(task):
node_bdev_names[al] = b
else:
node_bdev_names = {}
remote_devices = storage_node_ops._connect_to_remote_devs(node, reattach=False)
remote_devices = storage_node_ops._connect_to_remote_devs(node, reattach=False, force_connect_suspended_nodes=True)
if not remote_devices:
msg = "Node unable to connect to remote devs, retry task"
logger.info(msg)
Expand Down
6 changes: 5 additions & 1 deletion simplyblock_core/storage_node_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,8 @@ def _prepare_cluster_devices_on_restart(snode, clear_data=False):

def _connect_to_remote_devs(
this_node: StorageNode, /,
reattach: bool = True, force_connect_restarting_nodes: bool = False
reattach: bool = True, force_connect_restarting_nodes: bool = False,
force_connect_suspended_nodes: bool = False
):
db_controller = DBController()

Expand All @@ -1031,6 +1032,9 @@ def _connect_to_remote_devs(
allowed_node_statuses.append(StorageNode.STATUS_RESTARTING)
allowed_dev_statuses.append(NVMeDevice.STATUS_UNAVAILABLE)

if force_connect_suspended_nodes:
allowed_node_statuses.append(StorageNode.STATUS_SUSPENDED)

devices_to_connect = []
connect_threads = []
nodes = db_controller.get_storage_nodes_by_cluster_id(this_node.cluster_id)
Expand Down
Loading