feat: list[str] + case-insensitive support for assert_final_output(contains=...)#4
Open
Neohu-ceo wants to merge 1 commit into
Open
feat: list[str] + case-insensitive support for assert_final_output(contains=...)#4Neohu-ceo wants to merge 1 commit into
Neohu-ceo wants to merge 1 commit into
Conversation
Owner
|
Thanks for the PR, and for picking up a good first issue! The implementation looks correct and is backward-compatible. Single-string input with the default CI is failing on the coverage check, which points at the missing tests. The new branches (the No need to touch the CHANGELOG. I'll handle that on the maintainer side. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
assert_final_output(contains=...)with backward-compatible features (fixes #2):containsnow accepts a list; all substrings must matchExamples
equalsandmatchesunchanged. Defaultcase_sensitive=True— existing tests unaffected.