Display Hebrew month days in Hebrew letters, not numbers.#2
Open
udif wants to merge 1 commit intosindilevich:masterfrom
Open
Display Hebrew month days in Hebrew letters, not numbers.#2udif wants to merge 1 commit intosindilevich:masterfrom
udif wants to merge 1 commit intosindilevich:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modified luach.js so that the Hebrew month days will be displayed as Hebrew letters, not numbers. This has the advantage that it is very easy to distinguish between the gregorian month days and the Hebrew month days.
I am not a Java/Web programmer at all, but given google/stackexchange and my present C/C++ knowledge, it was easy to change. I don't know, however, if it is OK to put Hebrew letters directly in the code, or should have I entered those via \uXXXX notation.
Note that I haven't tested this change directly. I created this change directly on Kaluach's Firefox plugin, and patched this single line change into this repository.