Convert abstract base class to protocols#267
Merged
Merged
Conversation
aaronwolen
approved these changes
Feb 27, 2026
aaronwolen
left a comment
aaronwolen
left a comment
Member
There was a problem hiding this comment.
Had a couple questions along the way, but otherwise looks great.
Are there any dependencies we can drop now that much of the implementation code has been removed?
jp-dark
force-pushed
the
dark/abc-to-protocol
branch
from
45fdd1e to
3e5a62b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major re-write of the python specification. This change converts the abstract base classes defined in somacore and converts them to protocols. This allows more flexibility and fewer dependencies for downstream libraries that implement the SOMA interface.