feat(account): implement user fee rate endpoint (#80)#115
Open
ZainKazmiii wants to merge 5 commits into
Open
Conversation
Signed-off-by: Zain Kazmi <kazmiza@shernet.sheridancollege.ca>
Signed-off-by: Zain Kazmi <kazmiza@shernet.sheridancollege.ca>
Signed-off-by: Zain Kazmi <kazmiza@shernet.sheridancollege.ca>
Signed-off-by: Zain Kazmi <kazmiza@shernet.sheridancollege.ca>
Signed-off-by: Zain Kazmi <kazmiza@shernet.sheridancollege.ca>
Author
|
Validation update from clean PR-head rerun:
This supersedes the earlier runner note that dependencies could not be installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #80 (
Price: 10$) by wiring the missing account feature end-to-end.What changed
BingxUserFeeRateEndpointforGET /openApi/swap/v2/user/commissionRate.AccountService.getUserFeeRate(account, symbol?)that dispatches the new endpoint.src/bingx/endpoints/index.ts.src/bingx-client/services/account.service.spec.tsfor dispatch and optionalsymbolforwarding.User fee rateto checked.Validation
Validated on the current PR head (
a03308846e492e312e1d7dbcceeb19b9cdbcd9df) in a clean checkout:npm install --no-audit --no-fundPASSnpx tsc --noEmitPASSnpm run build --silentPASSnpx jest src/bingx-client/services/account.service.spec.ts --runInBandPASS (2 tests)