Skip to content

feat(account): implement user fee rate endpoint (#80)#115

Open
ZainKazmiii wants to merge 5 commits into
singlesly:mainfrom
ZainKazmiii:fix/80-user-fee-rate-endpoint-20260521
Open

feat(account): implement user fee rate endpoint (#80)#115
ZainKazmiii wants to merge 5 commits into
singlesly:mainfrom
ZainKazmiii:fix/80-user-fee-rate-endpoint-20260521

Conversation

@ZainKazmiii
Copy link
Copy Markdown

@ZainKazmiii ZainKazmiii commented May 21, 2026

Implements #80 (Price: 10$) by wiring the missing account feature end-to-end.

What changed

  • Added BingxUserFeeRateEndpoint for GET /openApi/swap/v2/user/commissionRate.
  • Added AccountService.getUserFeeRate(account, symbol?) that dispatches the new endpoint.
  • Exported the endpoint in src/bingx/endpoints/index.ts.
  • Added focused unit tests in src/bingx-client/services/account.service.spec.ts for dispatch and optional symbol forwarding.
  • Updated README feature status for User fee rate to checked.

Validation

Validated on the current PR head (a03308846e492e312e1d7dbcceeb19b9cdbcd9df) in a clean checkout:

  • npm install --no-audit --no-fund PASS
  • npx tsc --noEmit PASS
  • npm run build --silent PASS
  • npx jest src/bingx-client/services/account.service.spec.ts --runInBand PASS (2 tests)

Signed-off-by: Zain Kazmi <kazmiza@shernet.sheridancollege.ca>
Signed-off-by: Zain Kazmi <kazmiza@shernet.sheridancollege.ca>
Signed-off-by: Zain Kazmi <kazmiza@shernet.sheridancollege.ca>
Signed-off-by: Zain Kazmi <kazmiza@shernet.sheridancollege.ca>
Signed-off-by: Zain Kazmi <kazmiza@shernet.sheridancollege.ca>
@ZainKazmiii
Copy link
Copy Markdown
Author

Validation update from clean PR-head rerun:

  • Checkout: ZainKazmiii/bingx-api branch fix/80-user-fee-rate-endpoint-20260521 at a03308846e492e312e1d7dbcceeb19b9cdbcd9df
  • npm install --no-audit --no-fund -> PASS_AFTER_RETRY (first run hit spawn EPERM, immediate rerun passed)
  • npx tsc --noEmit -> PASS
  • npm run build --silent -> PASS
  • npx jest src/bingx-client/services/account.service.spec.ts --runInBand -> PASS (2 tests)

This supersedes the earlier runner note that dependencies could not be installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant