Skip to content

fix(#2692): Remove ESM-only supports-color as it breaks CJS exports#2693

Merged
fatso83 merged 4 commits intomainfrom
2692
Apr 10, 2026
Merged

fix(#2692): Remove ESM-only supports-color as it breaks CJS exports#2693
fatso83 merged 4 commits intomainfrom
2692

Conversation

@fatso83
Copy link
Copy Markdown
Contributor

@fatso83 fatso83 commented Apr 10, 2026

Purpose (TL;DR) - mandatory

Hopefully fixes 2692

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.29%. Comparing base (30cf67e) to head (c333a18).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2693   +/-   ##
=======================================
  Coverage   97.28%   97.29%           
=======================================
  Files          39       39           
  Lines        1771     1774    +3     
=======================================
+ Hits         1723     1726    +3     
  Misses         48       48           
Flag Coverage Δ
unit 97.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​npm-run-all@​4.1.5991009875100

View full report

@fatso83 fatso83 merged commit 2eabf5d into main Apr 10, 2026
15 checks passed
@fatso83 fatso83 deleted the 2692 branch April 10, 2026 20:47
Comment thread package.json
"@sinonjs/samsam": "^10.0.0",
"diff": "^8.0.4",
"supports-color": "^10.2.2"
"npm-run-all": "^4.1.5"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fatso83 was it intended to add this to dependencies? I believe it should be a devDep. noticed it because of a major jump in the number of dependencies in a downstream project.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created #2694 to fix

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, that was a post midnight slip up 🫣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants