Skip to content

chore: remove .github/decisions directory#269

Merged
froggy1014 merged 1 commit into
devfrom
chore/remove-decisions-evan
Apr 29, 2026
Merged

chore: remove .github/decisions directory#269
froggy1014 merged 1 commit into
devfrom
chore/remove-decisions-evan

Conversation

@froggy1014

Copy link
Copy Markdown
Contributor

요약

  • .github/decisions/ 디렉토리 삭제 (token-architecture.md, token-naming-convention.md, v1-audit.md)

질문

@3o14 원주님, 해당 파일들이 .github/decisions/에 위치한 게 의도적인 건가요?

ADR(Architecture Decision Records) 성격의 문서인데, .github/ 디렉토리는 보통 GitHub 메타 설정 파일 (workflows, ISSUE_TEMPLATE 등)이 위치하는 곳이라 다소 어색하게 느껴졌습니다.

관련 토큰 구현도 이미 완료된 것으로 보여 (feat(tokens): add Style Dictionary v5 pipeline 등) 삭제해도 무방하다고 판단했지만, 의도가 있었다면 말씀해 주세요!

만약 문서 보존이 필요하다면 docs/ 하위로 이동하는 방향도 고려할 수 있을 것 같습니다.

체크리스트

  • .github/decisions/ 내 파일 3개 삭제

@changeset-bot

changeset-bot Bot commented Apr 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1e405e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • main
  • release/v1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 05a3b83e-a439-4e3e-85a1-05aa1e57df85

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-decisions-evan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@3o14 3o14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기록의 목적은 이후 메인테이너가 되실 분들이 이전의 의사결정 근거들을 확인하실 수 있도록 맥락 아카이빙 용도에 가깝습니다. 제거보다는 남겨두는걸 희망해요. 위치는 상관없습니다.

아직까진 tokens 관련된 내용만 있어서 packages/tokens/docs/decisions/ 도 좋은 것 같네요.

강한 의견은 아니어서 우선 어프룹 해둘게요!

@froggy1014 froggy1014 merged commit de4dbdb into dev Apr 29, 2026
5 checks passed
@froggy1014 froggy1014 deleted the chore/remove-decisions-evan branch April 29, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants