feat: add TypeScript Cucumber Playwright BDD example#24
Open
sirockin wants to merge 3 commits into
Open
Conversation
- Implement ts-cucumber-playwright-bdd following contributing guidelines - Use playwright-bdd library for BDD test execution - Auto-generate TypeScript client from OpenAPI specification - Implement three protocol drivers: Domain, HTTP, and UI - Copy identical Gherkin feature files for consistency - Add comprehensive Makefile with same targets as Go examples - Support both command-line and Playwright UI test execution - Include detailed documentation in TESTING.md - Update main README.md with new TypeScript example - All domain tests passing (4/4 scenarios) Closes #23 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove domain-driver.ts and related files that reimplemented business logic - Remove playwright-domain.config.ts and domain test configurations - Update HTTP driver to test actual Go backend via API - Update Makefile and package.json to remove domain targets - Update documentation to reflect HTTP/UI focus on real system testing - HTTP tests now verify integration with actual backend (2/4 passing) This approach is more architecturally sound as it tests the real system instead of duplicating business logic in TypeScript. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements issue #23 by adding a comprehensive TypeScript Cucumber Playwright BDD example that demonstrates the same patterns as the existing Go examples.
✅ Requirements Fulfilled
ts-cucumber-playwright-bddfollowing contributing guidelinesplaywright-bddlibrary (v7.x) for BDD test execution🏗️ Architecture
Implements the same four-layer model as existing examples:
🧪 Test Results
Domain tests are passing (4/4 scenarios):
📁 Key Files Added
acceptance/ts-cucumber-playwright-bdd/- Complete TypeScript BDD implementationsrc/drivers/(domain, HTTP, UI)src/steps/domain-steps.tsTESTING.mddocumentationMakefilewith targets matching Go examplesREADME.mdto include new TypeScript example🎯 Test Plan
🤖 Generated with Claude Code