Skip to content

Fix/ghcup 0.1.0#146

Open
PhotonQuantum wants to merge 3 commits into
masterfrom
fix/ghcup-0.1.0
Open

Fix/ghcup 0.1.0#146
PhotonQuantum wants to merge 3 commits into
masterfrom
fix/ghcup-0.1.0

Conversation

@PhotonQuantum

Copy link
Copy Markdown
Member

Tested on schema version 0.1.0

Tested on schema version 0.1.0
the previous logic prefers 0.0.9 to 0.1.0
@definfo

definfo commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

LGTM, except that mod.rs comments might mention GhcupYaml usage.

@PhotonQuantum

Copy link
Copy Markdown
Member Author

For now I don't see any GhcupYaml mention that's outdated

⊢  rg "GhcupYaml"
src/ghcup/yaml.rs
18:pub struct GhcupYaml {
24:impl GhcupYaml {
31:        GhcupYaml {
40:impl SnapshotStorage<SnapshotMeta> for GhcupYaml {
93:impl SourceStorage<SnapshotMeta, TransferURL> for GhcupYaml {

src/ghcup/mod.rs
24:use crate::ghcup::yaml::GhcupYaml;
73:    pub fn get_yaml(&self, legacy: bool) -> GhcupYaml {
74:        GhcupYaml::new(self.ghcup_repo_config.clone(), legacy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants