feat!: rewrite module deps from loft-sh to skevetter forks#726
feat!: rewrite module deps from loft-sh to skevetter forks#726
Conversation
📝 WalkthroughWalkthroughReplaces import paths from Loft modules to skevetter equivalents across the repository, swaps platform option types from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- go.mod: loft-sh/agentapi/v4 → skevetter/agentapi v1.0.1 - go.mod: loft-sh/api/v4 → skevetter/api v1.1.0 - go.mod: loft-sh/apiserver → skevetter/apiserver v1.0.1 - go.mod: loft-sh/admin-apis → skevetter/admin-apis v1.0.0 - All Go imports rewritten to skevetter/* paths - agentapi: apis/loft → apis/devsy subpath - api: pkg/devpod → pkg/devsy subpath + type refs BREAKING CHANGE: All loft-sh module references replaced with skevetter forks.
80d9d7b to
6715b77
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 203: go.mod currently contains both github.com/loft-sh/admin-apis and
github.com/skevetter/admin-apis as indirect requirements (mirrored by similar
duplicates for agentapi/apiserver); remove the stale/old module entry
(github.com/loft-sh/admin-apis) and ensure all references and replace directives
point to the intended module (github.com/skevetter/admin-apis), then run go mod
tidy to prune unused indirect deps and verify the dependency graph no longer
contains the duplicate; check and update any replace directives or transitive
module requirements that reference agentapi/apiserver duplicates as part of the
same cleanup.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 014b05cf-0695-49f9-85ff-45a062e6abef
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (46)
cmd/pro/add/cluster.gocmd/pro/daemon/start.gocmd/pro/import_workspace.gocmd/pro/provider/create/workspace.gocmd/pro/provider/list/clusters.gocmd/pro/provider/list/projects.gocmd/pro/provider/list/templates.gocmd/pro/provider/list/workspaces.gocmd/pro/provider/status.gocmd/pro/provider/stop.gocmd/pro/provider/up.gocmd/pro/provider/update/workspace.gocmd/pro/provider/watch/workspaces.gocmd/pro/reset/password.gocmd/pro/sleep.gocmd/pro/start.gocmd/pro/wakeup.gocmd/troubleshoot.gogo.modpkg/agent/tunnelserver/options.gopkg/agent/tunnelserver/tunnelserver.gopkg/agent/workspace.gopkg/client/client.gopkg/client/clientimplementation/daemonclient/client.gopkg/client/clientimplementation/daemonclient/form.gopkg/client/clientimplementation/daemonclient/stop.gopkg/client/clientimplementation/daemonclient/up.gopkg/client/clientimplementation/proxy_client.gopkg/client/clientimplementation/services.gopkg/daemon/agent/daemon.gopkg/daemon/platform/client.gopkg/daemon/platform/local_server.gopkg/daemon/platform/workspace_watcher.gopkg/devcontainer/buildkit/remote.gopkg/devcontainer/setup/setup.gopkg/platform/client/client.gopkg/platform/form/form.gopkg/platform/instance.gopkg/platform/kube/kube.gopkg/platform/kubeconfig.gopkg/platform/owner.gopkg/platform/parameters/parameters.gopkg/platform/user.gopkg/provider/workspace.gopkg/tunnel/services.gopkg/workspace/list.go
✅ Files skipped from review due to trivial changes (20)
- cmd/pro/import_workspace.go
- cmd/pro/provider/stop.go
- pkg/platform/owner.go
- cmd/pro/provider/create/workspace.go
- pkg/client/clientimplementation/daemonclient/stop.go
- cmd/pro/provider/watch/workspaces.go
- pkg/client/clientimplementation/daemonclient/client.go
- pkg/client/clientimplementation/daemonclient/form.go
- pkg/platform/user.go
- pkg/workspace/list.go
- pkg/platform/client/client.go
- pkg/agent/workspace.go
- cmd/pro/provider/up.go
- pkg/provider/workspace.go
- cmd/pro/wakeup.go
- cmd/pro/start.go
- pkg/platform/kube/kube.go
- pkg/platform/form/form.go
- cmd/pro/reset/password.go
- pkg/devcontainer/setup/setup.go
🚧 Files skipped from review as they are similar to previous changes (19)
- cmd/pro/provider/status.go
- cmd/pro/add/cluster.go
- cmd/pro/provider/list/workspaces.go
- cmd/troubleshoot.go
- pkg/daemon/platform/workspace_watcher.go
- pkg/agent/tunnelserver/options.go
- pkg/tunnel/services.go
- pkg/client/client.go
- pkg/daemon/platform/local_server.go
- pkg/daemon/platform/client.go
- cmd/pro/provider/list/templates.go
- pkg/platform/parameters/parameters.go
- cmd/pro/provider/update/workspace.go
- pkg/daemon/agent/daemon.go
- pkg/client/clientimplementation/proxy_client.go
- cmd/pro/sleep.go
- cmd/pro/provider/list/projects.go
- pkg/client/clientimplementation/daemonclient/up.go
- pkg/agent/tunnelserver/tunnelserver.go
Bumps api to v1.0.1, agentapi to v1.0.0, apiserver to v1.0.2. All loft-sh indirect dependencies are now eliminated.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 42-44: Update the PR description to reflect the actual module
versions found in go.mod: change the listed versions for
github.com/skevetter/agentapi to v1.0.0, github.com/skevetter/api to v1.0.1, and
github.com/skevetter/apiserver to v1.0.2 (or explicitly explain why the
description shows different versions), ensuring the PR text matches the versions
of the modules named agentapi, api, and apiserver.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ac506a2c-cf5a-4828-b4dc-08c76fcc6af8
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| github.com/skevetter/agentapi v1.0.0 | ||
| github.com/skevetter/api v1.0.1 | ||
| github.com/skevetter/apiserver v1.0.2 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify the skevetter module versions exist
# Check agentapi v1.0.0
echo "Checking github.com/skevetter/agentapi@v1.0.0..."
curl -s "https://proxy.golang.org/github.com/skevetter/agentapi/@v/v1.0.0.info" | jq -r '.Version // "NOT FOUND"'
# Check api v1.0.1
echo "Checking github.com/skevetter/api@v1.0.1..."
curl -s "https://proxy.golang.org/github.com/skevetter/api/@v/v1.0.1.info" | jq -r '.Version // "NOT FOUND"'
# Check apiserver v1.0.2
echo "Checking github.com/skevetter/apiserver@v1.0.2..."
curl -s "https://proxy.golang.org/github.com/skevetter/apiserver/@v/v1.0.2.info" | jq -r '.Version // "NOT FOUND"'
# Check admin-apis v1.0.0
echo "Checking github.com/skevetter/admin-apis@v1.0.0..."
curl -s "https://proxy.golang.org/github.com/skevetter/admin-apis/@v/v1.0.0.info" | jq -r '.Version // "NOT FOUND"'Repository: skevetter/devpod
Length of output: 281
Update PR description to match actual dependency versions.
Verified that all module versions in the code exist and are valid. However, the PR description states different versions than what's actually specified:
agentapi: PR says v1.0.1, code has v1.0.0api: PR says v1.1.0, code has v1.0.1apiserver: PR says v1.0.1, code has v1.0.2
Update the PR description to reflect the correct versions, or clarify why the versions differ from what was documented.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` around lines 42 - 44, Update the PR description to reflect the actual
module versions found in go.mod: change the listed versions for
github.com/skevetter/agentapi to v1.0.0, github.com/skevetter/api to v1.0.1, and
github.com/skevetter/apiserver to v1.0.2 (or explicitly explain why the
description shows different versions), ensuring the PR text matches the versions
of the modules named agentapi, api, and apiserver.
loft-sh/*toskevetter/*forksapis/loft→apis/devsypkg/devpod→pkg/devsy+ type referencesSummary by CodeRabbit